Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activity feed dashboard link #9128

Closed
pmbrull opened this issue Dec 2, 2022 · 2 comments
Closed

Fix activity feed dashboard link #9128

pmbrull opened this issue Dec 2, 2022 · 2 comments
Assignees
Labels
backend bug Something isn't working P0 Highest priority UI UI specific issues

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Dec 2, 2022

Activity feed from Metabase creates the link properly as /dashboard/...

In Looker we are creating it as /table/...

@pmbrull pmbrull changed the title Fix activity feed Fix activity feed dashboard link Dec 2, 2022
@pmbrull pmbrull added the UI UI specific issues label Dec 2, 2022
@pmbrull pmbrull added the bug Something isn't working label Dec 2, 2022
@aniketkatkar97 aniketkatkar97 moved this to 🔖 Ready in Release 0.13.1 Dec 2, 2022
@aniketkatkar97
Copy link
Member

As of now, we don't have a page dedicated to showing chart details, there won't be a proper link to redirect the user.
We will handle this issue later as we are thinking about adding the chart details page.

@Ashish8689
Copy link
Contributor

Ashish8689 commented May 16, 2023

@mohityadav766 @harshach

For the dashboard chart entity feed, we are not getting the correct entity link, for example, we have dashboard sample_looker.customers and it has charts chart_1 and chart_2. so if we make any changes to chart_1, the change event is generated, however, the about attribute has the wrong entity link.

It has <E::chart::sample_looker.chart_1>, instead of <E::chart::sample_looker.customers.chart_1>

image

@TeddyCr TeddyCr removed this from Release 1.2 Jun 30, 2023
@harshach harshach added this to Backlog Oct 22, 2023
@harshach harshach removed this from Backlog Oct 22, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.3.0 Oct 22, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.4.0 Jan 26, 2024
@pmbrull pmbrull removed this from Release 1.4.0 Apr 8, 2024
@pmbrull pmbrull added the P0 Highest priority label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working P0 Highest priority UI UI specific issues
Projects
None yet
Development

No branches or pull requests

4 participants