Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quicktype type generation is failing without any error being printed #10811

Closed
chirag-madlani opened this issue Mar 29, 2023 · 2 comments
Closed
Assignees
Labels
UI UI specific issues

Comments

@chirag-madlani
Copy link
Collaborator

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI -- Build

Describe the bug
A clear and concise description of what the bug is.

  • Quicktype type generation step on UI is failing without printing any errors.
  • We should have clear messages if any types fail to create and should not block the thread itself.
  • Currently of failing types step is being blocked

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@chirag-madlani chirag-madlani self-assigned this Mar 29, 2023
@chirag-madlani chirag-madlani added the UI UI specific issues label Mar 29, 2023
@harshach harshach removed this from Release 1.0 Apr 25, 2023
@harshach harshach moved this to UI in Release 1.1 May 8, 2023
@chirag-madlani chirag-madlani removed their assignment May 29, 2023
@phalix
Copy link

phalix commented May 31, 2023

There are several issues with the quicktype generation right now.

First emailVerificationToken defines the following:
"required": [
"token",
"user",
"tokenType",
"tokenStatus",
"expiryDate"
],

Though there is no type user, but a type userid.

In addition the $id of several classes do not match the path they are actually in. E.g. createWebAnalyticEvent.json defines the $id as https://open-metadata.org/schema/api/tests/createWebAnalyticEvent.json, though the actual path is /api/analytics/createWebAnalyticEvent.json.

Lastly, I ran into problems due to the usage of https://open-metadata.org in the id, which caused the quicktype generator to constantly do http request, which also lead to blocked requests.

If you want to have a detailed log of the generation, you can always --debug all on the quicktype command on json2ts.sh:
./node_modules/.bin/quicktype -s schema $PWD"/${schema_directory}$1" -o $PWD"/"$om_ui_directory$2 --just-types --debug all > output.log 2>&1

Also I put the output to a file.

@Sachin-chaurasiya
Copy link
Contributor

Fixed with this #12335 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants