-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix links to the openfeature ecosystem page #432
Conversation
Because of the missing slash before the parameters, the site does not perceive the request correctly. The site adds the slash it needs to the request, but ignores the parameters passed. And when clicking on the link from the readme file, the user sees a blank page. This is not a problem_PROBLEM, but if it can be fixed, why not fix it. The problem is reproduced on Chrome and Edge browsers Signed-off-by: Maxim <[email protected]>
Hey @therb1, good catch and thanks for the PR. Could you please also update the link in the hooks section? That's also invalid. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 31 31
Lines 1393 1393
=======================================
Hits 1359 1359
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No problem, give me couple minutes |
@beeme1mr where did the documentation move? |
fix example hooks url Signed-off-by: Maxim <[email protected]>
I corrected the link to hooks. |
This PR
The parameter in the form has changed from
python
toPython
.Now the link from readme.md goes to a blank page.
I also added end_slash to the link, if the site does it, then why not do it right away.
Notes
This is not a problem_PROBLEM, but if it can be fixed, why not fix it.
Follow-up Tasks
How to test
Chrome incognito mode