Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix links to the openfeature ecosystem page #432

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

therb1
Copy link
Contributor

@therb1 therb1 commented Feb 5, 2025

This PR

  1. The parameter in the form has changed from python to Python.
    Now the link from readme.md goes to a blank page.

  2. I also added end_slash to the link, if the site does it, then why not do it right away.

Notes

This is not a problem_PROBLEM, but if it can be fixed, why not fix it.

Follow-up Tasks

How to test

Chrome incognito mode

Because of the missing slash before the parameters, the site does not perceive the request correctly. The site adds the slash it needs to the request, but ignores the parameters passed. And when clicking on the link from the readme file, the user sees a blank page. This is not a problem_PROBLEM, but if it can be fixed, why not fix it.

The problem is reproduced on Chrome and Edge browsers

Signed-off-by: Maxim <[email protected]>
@beeme1mr beeme1mr changed the title Update README.md docs: fix links to the openfeature ecosystem page Feb 5, 2025
@beeme1mr
Copy link
Member

beeme1mr commented Feb 5, 2025

Hey @therb1, good catch and thanks for the PR. Could you please also update the link in the hooks section? That's also invalid.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (fe0fea1) to head (90de0a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          31       31           
  Lines        1393     1393           
=======================================
  Hits         1359     1359           
  Misses         34       34           
Flag Coverage Δ
unittests 97.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@therb1
Copy link
Contributor Author

therb1 commented Feb 5, 2025

Hey @therb1, good catch and thanks for the PR. Could you please also update the link in the hooks section? That's also invalid.

No problem, give me couple minutes

@therb1
Copy link
Contributor Author

therb1 commented Feb 5, 2025

@beeme1mr where did the documentation move?
I found another broken link docs/reference/concepts/evaluation-context

fix example hooks url

Signed-off-by: Maxim <[email protected]>
@therb1
Copy link
Contributor Author

therb1 commented Feb 5, 2025

I corrected the link to hooks.

@beeme1mr
Copy link
Member

beeme1mr commented Feb 5, 2025

Hey @therb1, the main docs can be found in this repo.

@beeme1mr beeme1mr merged commit 49edce2 into open-feature:main Feb 5, 2025
15 checks passed
This was referenced Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants