-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eval context fixes and new error types #43
fix: eval context fixes and new error types #43
Conversation
Signed-off-by: Robert Grassian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 93.59% 92.78% -0.82%
==========================================
Files 17 17
Lines 281 291 +10
==========================================
+ Hits 263 270 +7
- Misses 18 21 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgrassian-split, totally agree with the new approach for the context merging, thanks for submitting this. I've added some comments in a few places.
Signed-off-by: Robert Grassian <[email protected]>
Signed-off-by: Robert Grassian <[email protected]>
@matthewelwell @ajhelsby any concerns about merging this? |
Signed-off-by: Robert Grassian [email protected]
This PR
TargetingKeyMissingError
andInvalidContextError
, along with their error codes