feat: add FeatureProvider protocol #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 93.94% 94.02% +0.08%
==========================================
Files 16 17 +1
Lines 446 452 +6
==========================================
+ Hits 419 425 +6
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
federicobond
force-pushed
the
feature-provider
branch
from
020dbbf to
c73fc49
Compare
Signed-off-by: Federico Bond <[email protected]>
federicobond
force-pushed
the
feature-provider
branch
from
c73fc49 to
c180405
Compare
beeme1mr
approved these changes
Feb 2, 2024
gruebel
approved these changes
Feb 3, 2024
Co-authored-by: Anton Grübel <[email protected]> Signed-off-by: Federico Bond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new FeatureProvider protocol. Public API methods can use it as an argument type when they want to denote any provider, instead of AbstractProvider which is a bit clunky.
AbstractProvider remains as a provider base class for backward compatibility but it's import path at
openfeature.provider.providerdoes not have the best ergonomics and we should begin working on a migration path before 1.0 is released.