Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadata to providers #26

Merged
merged 4 commits into from
Oct 18, 2022
Merged

feat: Add metadata to providers #26

merged 4 commits into from
Oct 18, 2022

Conversation

ajhelsby
Copy link
Contributor

This PR

This PR adds a metadata dataclass to the providers

  • New Metadata dataclass that can be extended by the providers

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
# Conflicts:
#	open_feature/provider/no_op_provider.py
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #26 (041d431) into main (b44224b) will increase coverage by 1.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   84.32%   85.40%   +1.08%     
==========================================
  Files          15       17       +2     
  Lines         268      281      +13     
==========================================
+ Hits          226      240      +14     
+ Misses         42       41       -1     
Flag Coverage Δ
unittests 85.40% <100.00%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/provider/metadata.py 100.00% <100.00%> (ø)
open_feature/provider/no_op_metadata.py 100.00% <100.00%> (ø)
open_feature/provider/no_op_provider.py 94.73% <100.00%> (+6.50%) ⬆️
open_feature/provider/provider.py 75.00% <100.00%> (+1.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
@ajhelsby ajhelsby merged commit b39cced into main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants