Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move api hooks methods to api module #169

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

federicobond
Copy link
Member

This change does something similar to #164 but for the hooks API. Imports should be updated from:

from open_feature.hooks import api_hooks, add_api_hooks

To:

from open_feature.open_feature_api import get_hooks, add_hooks

This ensures all API-level methods are accessible from the same module.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #169 (49a9c79) into main (9e1bcb3) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   94.15%   93.47%   -0.68%     
==========================================
  Files          24       23       -1     
  Lines         462      460       -2     
==========================================
- Hits          435      430       -5     
- Misses         27       30       +3     
Flag Coverage Δ
unittests 93.47% <100.00%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
open_feature/open_feature_client.py 95.87% <ø> (-0.05%) ⬇️
open_feature/open_feature_api.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

open_feature/open_feature_api.py Show resolved Hide resolved
@federicobond federicobond merged commit a7da26f into open-feature:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants