Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flagd in-process provider #412

Merged
merged 32 commits into from
Sep 7, 2023
Merged

feat: flagd in-process provider #412

merged 32 commits into from
Sep 7, 2023

Conversation

Kavindu-Dodan
Copy link
Collaborator

@Kavindu-Dodan Kavindu-Dodan commented Sep 1, 2023 •
edited
Loading

This PR

Completes first set of tasks proposed through #411

Please review with checkout as this contains refactoring + implementation of the in-process resolver for flagd.

Design

Consider the following diagram for architecture,

image

Highlights

  • No API changes, hence no breaking changes
  • Resolver selection through builder option,
       // This builds a flagd provider with in-memory resolving
        new FlagdProvider(
                FlagdOptions.builder()
                        .resolverType(Config.ResolverType.inProcess)
                        .build());
  • Extensibility through layering and contracts
  • Feature parity with grpc evaluator (i.e - Eventing, targeting rules and matching evaluation payloads)

Kavindu-Dodan
Kavindu-Dodan commented Sep 1, 2023
View reviewed changes
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/flagd-in-process branch 3 times, most recently from 7598b4c to 6f29db3 Compare September 4, 2023 22:08
@Kavindu-Dodan Kavindu-Dodan marked this pull request as ready for review September 4, 2023 22:27
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner September 4, 2023 22:27
thisthat
thisthat reviewed Sep 5, 2023
View reviewed changes
@beeme1mr beeme1mr changed the title feat: flagd in-process prociess provider feat: flagd in-process process provider Sep 5, 2023
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/flagd-in-process branch 7 times, most recently from b784edb to f11f380 Compare September 5, 2023 22:08
thisthat
thisthat reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation LGTM, great work @Kavindu-Dodan 👏
I suggest adding some unit tests for the gRPC Stream Handler/Connector and the FlagStore.
Please, also adapt the main readme with the new usage options :) I suggest also posting there (or in another doc) the nice diagram that you attached to this PR

toddbaert
toddbaert reviewed Sep 6, 2023
View reviewed changes
toddbaert
toddbaert reviewed Sep 6, 2023
View reviewed changes
Kavindu-Dodan and others added 16 commits September 7, 2023 11:13
@Kavindu-Dodan
connector refactored
fc5f344 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
doc comments and organize
22246fe 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
event handling wiring
e46c62c 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
resolving tests
bd53b6b 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
lint fixes
2bcde9b 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
review changes and fix lint
bda533f 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
schema validation, tests and lint
009ae86 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
spotbug fixes
aa61605 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
fix submodule status
a895402 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
disable e2e testst till framework is ready
2b88c08 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
fix exclusions
d7e0c54 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/src/main/java/dev/openfeature/contrib/provider…
d3888ad 
…s/flagd/resolver/process/model/FlagParser.java

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
fix test harness and review changes
da9e252 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
fix object resolving
d74b3f9 
Signed-off-by: Kavindu Dodanduwa <[email protected]>

fix test harness and review changes
@Kavindu-Dodan
testing storage connector contract
cc8bdc6 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
tests for grpc connector
2e4677c 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan and others added 9 commits September 7, 2023 12:49
@Kavindu-Dodan
documentation
81fb334 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
reset retry
96240a7 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…
63d9d0e 
…s/flagd/resolver/process/storage/FlagStoreTest.java

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…
e90a954 
…s/flagd/resolver/process/InProcessResolverTest.java

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…
a0915b0 
…s/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnectorTest.java

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @toddbaert
Update providers/flagd/README.md
7ce88e6 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan @thisthat
Update providers/flagd/src/test/java/dev/openfeature/contrib/provider…
a24dfab 
…s/flagd/resolver/process/model/FlagParserTest.java

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
add tests for int and double
c8ba6ee 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan
make wait configurable
729c1e6 
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan merged commit 7accd1e into open-feature:main Sep 7, 2023
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Merged
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@renovate
chore(deps): update github/codeql-action digest to f31a31c (open-feat…
be9d652 
…ure#412)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@toddbaert toddbaert toddbaert approved these changes

@odubajDT odubajDT odubajDT approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

Assignees

@beeme1mr beeme1mr

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kavindu-Dodan @thisthat @toddbaert @odubajDT @beeme1mr @thomaspoignant