Skip to content

Commit 3a9c916

Browse files
authored
feat: add JUnit Pioneer as testing dependency (#820)
Signed-off-by: Simon Schrottner <[email protected]>
1 parent d1518cf commit 3a9c916

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

pom.xml

+9-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<version>1.18.32</version>
7373
<scope>provided</scope>
7474
</dependency>
75-
75+
7676
<dependency>
7777
<!-- used so that lombok can generate suppressions for spotbugs. It needs to find it on the relevant classpath -->
7878
<groupId>com.github.spotbugs</groupId>
@@ -140,6 +140,13 @@
140140
<scope>test</scope>
141141
</dependency>
142142

143+
<dependency>
144+
<groupId>org.junit-pioneer</groupId>
145+
<artifactId>junit-pioneer</artifactId>
146+
<version>1.9.1</version>
147+
<scope>test</scope>
148+
</dependency>
149+
143150
<dependency>
144151
<groupId>org.mockito</groupId>
145152
<artifactId>mockito-junit-jupiter</artifactId>
@@ -435,4 +442,4 @@
435442
<url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
436443
</repository>
437444
</distributionManagement>
438-
</project>
445+
</project>

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import io.opentelemetry.api.OpenTelemetry;
44
import org.junit.jupiter.api.Disabled;
55
import org.junit.jupiter.api.Test;
6+
import org.junitpioneer.jupiter.SetEnvironmentVariable;
67
import org.mockito.Mockito;
78

89
import java.util.function.Function;
@@ -88,7 +89,7 @@ void testValueProviderForEdgeCase_invalid() {
8889
}
8990

9091
@Test
91-
@Disabled("Currently there is no defined way on how to set environment variables for tests")
92+
@SetEnvironmentVariable(key = RESOLVER_ENV_VAR, value = RESOLVER_IN_PROCESS)
9293
void testInProcessProviderFromEnv_noPortConfigured_defaultsToCorrectPort() {
9394
FlagdOptions flagdOptions = FlagdOptions.builder().build();
9495

@@ -107,7 +108,7 @@ void testInProcessProvider_noPortConfigured_defaultsToCorrectPort() {
107108
}
108109

109110
@Test
110-
@Disabled("Currently there is no defined way on how to set environment variables for tests")
111+
@SetEnvironmentVariable(key = RESOLVER_ENV_VAR, value = RESOLVER_IN_PROCESS)
111112
void testInProcessProviderFromEnv_portConfigured_usesConfiguredPort() {
112113
FlagdOptions flagdOptions = FlagdOptions.builder()
113114
.port(1000)
@@ -118,7 +119,7 @@ void testInProcessProviderFromEnv_portConfigured_usesConfiguredPort() {
118119
}
119120

120121
@Test
121-
@Disabled("Currently there is no defined way on how to set environment variables for tests")
122+
@SetEnvironmentVariable(key = RESOLVER_ENV_VAR, value = RESOLVER_RPC)
122123
void testRpcProviderFromEnv_noPortConfigured_defaultsToCorrectPort() {
123124
FlagdOptions flagdOptions = FlagdOptions.builder().build();
124125

@@ -137,7 +138,7 @@ void testRpcProvider_noPortConfigured_defaultsToCorrectPort() {
137138
}
138139

139140
@Test
140-
@Disabled("Currently there is no defined way on how to set environment variables for tests")
141+
@SetEnvironmentVariable(key = RESOLVER_ENV_VAR, value = RESOLVER_RPC)
141142
void testRpcProviderFromEnv_portConfigured_usesConfiguredPort() {
142143
FlagdOptions flagdOptions = FlagdOptions.builder()
143144
.port(1534)

0 commit comments

Comments
 (0)