fix: send datasync on remove fs events #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/sync-removes
branch
from
c32d6ff to
ae57cb8
Compare
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jan 28, 2023
|
Bypassing branch protection in order to release this bug fix because updates don't work in Kubernetes environments that are in file watching mode. |
beeme1mr
added a commit
that referenced
this pull request
Jan 28, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.3](v0.3.2...v0.3.3) (2023-01-28) ### Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.5.0 ([#326](#326)) ([7f332e5](7f332e5)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.26 ([#331](#331)) ([be67e5f](be67e5f)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.27 ([#335](#335)) ([824cf1a](824cf1a)) * send datasync on remove fs events ([#339](#339)) ([4c9aaac](4c9aaac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like during a refactor, we accidentally removed the "meat" of the remove handler.
In K8S, we never get write events, just remove. It's necessary to send the data for these as well.
Also extracted some duplicated code into a func.