Skip to content

Commit 79def47

Browse files
WeihanLibenjiro
andauthored
chore(deps): Project file cleanup and remove unnecessary dependencies (#251)
## This PR - simplify the `InternalsVisibleTo` usage - cleanup msbuild condition - remove unnecessary dependencies --------- Signed-off-by: Weihan Li <[email protected]> Co-authored-by: Benjamin Evenson <[email protected]>
1 parent ab34c16 commit 79def47

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

build/Common.props

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
</PropertyGroup>
1919

2020
<ItemGroup>
21-
<PackageReference Include="System.Collections.Immutable" />
22-
<PackageReference Include="System.Threading.Channels" />
21+
<PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
22+
<PackageReference Include="System.Threading.Channels" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
2323
</ItemGroup>
2424

2525
<ItemGroup Condition="'$(OS)' == 'Unix'">

src/OpenFeature/OpenFeature.csproj

+4-11
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,14 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462'" />
11-
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
10+
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
1211
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
1312
</ItemGroup>
1413

1514
<ItemGroup>
16-
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
17-
<_Parameter1>OpenFeature.Benchmarks</_Parameter1>
18-
</AssemblyAttribute>
19-
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
20-
<_Parameter1>OpenFeature.Tests</_Parameter1>
21-
</AssemblyAttribute>
22-
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
23-
<_Parameter1>OpenFeature.E2ETests</_Parameter1>
24-
</AssemblyAttribute>
15+
<InternalsVisibleTo Include="OpenFeature.Benchmarks" />
16+
<InternalsVisibleTo Include="OpenFeature.Tests" />
17+
<InternalsVisibleTo Include="OpenFeature.E2ETests" />
2518
<None Include="../../README.md" Pack="true" PackagePath="/" />
2619
</ItemGroup>
2720

0 commit comments

Comments
 (0)