feat(gofeatureflag): Provider refactor #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspoignant
force-pushed
the
feat-goff-exporter-metadata
branch
19 times, most recently
from
a0af470 to
e45465c
Compare
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
feat-goff-exporter-metadata
branch
from
e45465c to
a29981b
Compare
askpt
approved these changes
Feb 10, 2025
| @@ -53,6 +69,10 @@ private void ValidateInputOptions(GoFeatureFlagProviderOptions options) | |||
| /// <param name="options">Options used while creating the provider</param> | |||
| private void InitializeProvider(GoFeatureFlagProviderOptions options) | |||
| { | |||
| _exporterMetadata = options.ExporterMetadata ?? new ExporterMetadata(); | |||
| _exporterMetadata.Add("provider", ".NET"); | |||
There was a problem hiding this comment.
Should it be?
Suggested change
| _exporterMetadata.Add("provider", ".NET"); | |
| _exporterMetadata.Add("provider", "GoFeatureFlag .NET"); |
There was a problem hiding this comment.
Since this is used by GOFF internally .NET is enough in that case.
MJRichardson
pushed a commit
to OctopusDeploy/openfeature-dotnet-sdk-contrib
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Michael Richardson <[email protected]>
MJRichardson
pushed a commit
to OctopusDeploy/openfeature-dotnet-sdk-contrib
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Michael Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
In this PR we have done a few refactoring for the GO Feature Flag provider.
Here is the list of changes: