-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Environment Variable Provider #312
feat: Environment Variable Provider #312
Conversation
80a729c
to
9cd7c02
Compare
Greetings @MJRichardson, could you please also update release-please-config.json? There's also seems to a lint issue. Sorry for the delay on the review. Feel free to ping me if the PR get stuck again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I dropped a few minor suggestions. I advise you to run dotnet format
in the repository's root to correct formatting errors.
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Co-authored-by: André Silva <[email protected]> Signed-off-by: Michael Richardson <[email protected]> Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
Signed-off-by: Michael Richardson <[email protected]>
52b1643
to
6a0125e
Compare
Howdy @beeme1mr, and thanks :) I've made those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I just left one comment about the readme. Thanks for the contribution!
8141eb9
to
d3c4cad
Compare
1c00ec3
to
8141eb9
Compare
Signed-off-by: Michael Richardson <[email protected]>
8141eb9
to
21dbdbb
Compare
@beeme1mr While rebasing to sign my commits, I inadvertently signed commits which caused other reviewers to be added to the PR 🤦 |
Hey @MJRichardson, the provider is now available in NuGet. Thanks for the contribution! https://www.nuget.org/packages/OpenFeature.Contrib.Providers.EnvVar |
Environment Variable Provider
This PR adds a provider that evaluates environment variables.
It will use the flag key as the name of the environment variable, but also provides the ability for a common prefix to be supplied when the provider is created.