Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): #194 make STJ conditional #196

Merged
merged 3 commits into from
May 14, 2024
Merged

chore(deps): #194 make STJ conditional #196

merged 3 commits into from
May 14, 2024

Conversation

thompson-tomo
Copy link
Contributor

This PR

  • Makes STJ only included for net framework & net standard

Related Issues

Fixes #194

@thompson-tomo thompson-tomo requested review from a team as code owners May 2, 2024 21:06
@thompson-tomo thompson-tomo force-pushed the chore/#194_TweakSTJInclusion branch from 7934675 to cc4a6e2 Compare May 2, 2024 21:07
@thompson-tomo thompson-tomo changed the title #194 make STJ conditional Chore #194 make STJ conditional May 2, 2024
@thompson-tomo thompson-tomo changed the title Chore #194 make STJ conditional chore(deps): #194 make STJ conditional May 2, 2024
@github-actions github-actions bot mentioned this pull request May 4, 2024
Closed
@thomaspoignant
Copy link
Member

ok for GO Feature Flag

@thompson-tomo thompson-tomo force-pushed the chore/#194_TweakSTJInclusion branch from cc4a6e2 to b5fcc79 Compare May 7, 2024 09:12
toddbaert
toddbaert reviewed May 8, 2024
View reviewed changes
@toddbaert
Copy link
Member

@thompson-tomo Looks like there are some test-failures related to this assembly now. Do we have to change something about the test environment to support this? https://github.com/open-feature/dotnet-sdk-contrib/actions/runs/8982771607/job/24731590610?pr=196

@thompson-tomo
Copy link
Contributor Author

@thompson-tomo Looks like there are some test-failures related to this assembly now. Do we have to change something about the test environment to support this? https://github.com/open-feature/dotnet-sdk-contrib/actions/runs/8982771607/job/24731590610?pr=196

My apologies i made a mistake with the conditional package management hence on net 5 was complaining about the STJ missing a feature introduced with v6 so have adjusted the condition to also include stj for net 5.

@thompson-tomo thompson-tomo force-pushed the chore/#194_TweakSTJInclusion branch from 54b26f0 to ee3679c Compare May 8, 2024 16:10
@thompson-tomo
open-feature#194 make STJ conditional
1d59fad 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Fix build error
2869898 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo thompson-tomo force-pushed the chore/#194_TweakSTJInclusion branch from ee3679c to 2869898 Compare May 8, 2024 16:10
@beeme1mr beeme1mr merged commit 5987a5b into open-feature:main May 14, 2024
7 checks passed
This was referenced May 13, 2024
Merged
Merged
@thompson-tomo thompson-tomo deleted the chore/#194_TweakSTJInclusion branch May 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

@vpetrusevici vpetrusevici Awaiting requested review from vpetrusevici

Assignees

@matthewelwell matthewelwell

@thomaspoignant thomaspoignant

@vpetrusevici vpetrusevici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise dependencies
6 participants
@thompson-tomo @thomaspoignant @toddbaert @beeme1mr @matthewelwell @vpetrusevici