Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renames AMT, CIM, IPS classes to Messages #29

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

matt-primrose
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

BREAKING CHANGE: Resolves stutter when instantiating class. Ex. instead of new AMT.AMT() now is new AMT.Messages(), the same follows for IPS and CIM

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@matt-primrose matt-primrose requested a review from rsdmike January 6, 2022 17:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #29 (005884a) into main (ed4b16e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files          15       15           
  Lines         496      496           
  Branches      100      100           
=======================================
  Hits          461      461           
  Misses         35       35           
Impacted Files Coverage Δ
src/amt/index.ts 100.00% <100.00%> (ø)
src/amt/messages.ts 93.16% <100.00%> (ø)
src/cim/index.ts 100.00% <100.00%> (ø)
src/cim/messages.ts 93.33% <100.00%> (ø)
src/ips/messages.ts 60.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4b16e...005884a. Read the comment docs.

BREAKING CHANGE: Resolves stutter when instantiating class. Ex. instead of `new AMT.AMT()` now is `new AMT.Messages()`, the same follows for IPS and CIM
@matt-primrose matt-primrose merged commit 4470042 into main Jan 6, 2022
@matt-primrose matt-primrose deleted the semantic-release branch January 6, 2022 17:46
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants