Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #661 - don't try to access a zero length body #734

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

orinem
Copy link
Contributor

@orinem orinem commented Nov 20, 2022

PR Checklist

  • Unit Tests have been added for new changes
  • All commented code has been removed

What are you changing?

Fix for issue #661.

Anything the reviewer should know when reviewing this PR?

See discussion for issue #661. The test uses the exact message that caused the problem. Note that in spite of 'body' not being optional in HttpZResponseModel, it wasn't present in this case.

Also fixed text for the previous last test, the return is an empty string, not null.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@fc56834). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 3033315 differs from pull request most recent head 53b37c5. Consider uploading reports for the commit 53b37c5 to get more accurate results

@@           Coverage Diff           @@
##             main     #734   +/-   ##
=======================================
  Coverage        ?   93.36%           
=======================================
  Files           ?       78           
  Lines           ?     3288           
  Branches        ?      528           
=======================================
  Hits            ?     3070           
  Misses          ?      218           
  Partials        ?        0           
Impacted Files Coverage Δ
src/utils/parseWSManResponseBody.ts 92.85% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matt-primrose matt-primrose linked an issue Nov 21, 2022 that may be closed by this pull request
@rsdmike rsdmike enabled auto-merge (squash) November 22, 2022 17:39
@rsdmike rsdmike merged commit 98c6a3f into device-management-toolkit:main Nov 22, 2022
@orinem orinem deleted the issue_661 branch November 22, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in parseBody (parseWSManResponseBody.ts)
3 participants