Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): updated event log #463

Merged
merged 2 commits into from
Dec 15, 2021
Merged

refactor(api): updated event log #463

merged 2 commits into from
Dec 15, 2021

Conversation

madhavilosetty-intel
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #463 (ec92e29) into main (9adf30f) will increase coverage by 1.61%.
The diff coverage is 93.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   64.90%   66.51%   +1.61%     
==========================================
  Files          45       46       +1     
  Lines        1912     2028     +116     
  Branches      309      331      +22     
==========================================
+ Hits         1241     1349     +108     
- Misses        671      679       +8     
Impacted Files Coverage Δ
src/amt/ConnectedDevice.ts 54.43% <63.15%> (+1.19%) ⬆️
src/routes/amt/eventLog.ts 98.61% <98.41%> (ø)
src/amt/amt/AMT.ts 97.38% <100.00%> (+0.22%) ⬆️
src/amt/amt/actions.ts 100.00% <100.00%> (ø)
src/amt/amt/classes.ts 100.00% <100.00%> (ø)
src/amt/amt/methods.ts 100.00% <100.00%> (ø)
src/routes/amt/getGeneralSettings.ts 100.00% <100.00%> (ø)
src/routes/amt/getHardwareInfo.ts 100.00% <100.00%> (ø)
src/routes/amt/getPowerState.ts 100.00% <100.00%> (ø)
src/routes/amt/getVersion.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adf30f...ec92e29. Read the comment docs.

@madhavilosetty-intel madhavilosetty-intel changed the title 4552 eventlog refactor(api): updated eevnt log Dec 13, 2021
@madhavilosetty-intel madhavilosetty-intel changed the title refactor(api): updated eevnt log refactor(api): updated event log Dec 13, 2021
@madhavilosetty-intel madhavilosetty-intel force-pushed the 4552-eventlog branch 2 times, most recently from 9b64e8f to 7299659 Compare December 14, 2021 21:05
@madhavilosetty-intel madhavilosetty-intel merged commit 2438bbd into main Dec 15, 2021
@madhavilosetty-intel madhavilosetty-intel deleted the 4552-eventlog branch December 15, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants