Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): added unit test for db(pg) #430

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

madhavilosetty-intel
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Added unit tests for database(postgres) interactions

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #430 (9e71c2c) into main (5db2b6c) will increase coverage by 1.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   24.94%   26.81%   +1.87%     
==========================================
  Files          69       69              
  Lines        3757     3759       +2     
  Branches      804      804              
==========================================
+ Hits          937     1008      +71     
+ Misses       2435     2371      -64     
+ Partials      385      380       -5     
Impacted Files Coverage Δ
src/data/postgres/tables/device.ts 100.00% <100.00%> (+92.59%) ⬆️
src/data/postgres/index.ts 100.00% <0.00%> (+53.84%) ⬆️
src/utils/MPSValidationError.ts 100.00% <0.00%> (+83.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db2b6c...9e71c2c. Read the comment docs.

@madhavilosetty-intel madhavilosetty-intel merged commit ecc42f7 into main Nov 19, 2021
@madhavilosetty-intel madhavilosetty-intel deleted the 4354-db-unit-test branch November 19, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants