Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Side-effect integration testing #5748

Closed
Tracked by #5912
devbugging opened this issue Apr 22, 2024 · 4 comments
Closed
Tracked by #5912

[EVM] Side-effect integration testing #5748

devbugging opened this issue Apr 22, 2024 · 4 comments
Assignees
Labels
Flow EVM Stale Label used when marking an issue stale.

Comments

@devbugging
Copy link
Contributor

Executing EVM transactions with different combinations of modifications to the state can lead to unwanted side-effects between transactions. With the introduction of Cadence arch and batch transactions that risk increased.

We want to have a set of tests that focus on detecting how a combination of different interactions should not have unpredicted side-effects.

We should write tests that run a different combination (possibly at random) with batch transactions and different Cadence arch interactions and make sure the state after is as expected.

@devbugging
Copy link
Contributor Author

maybe if you have time just add an extra test in emulator or evm with a sequence of transactions (each emit an event and update a value) like this:
Successful, Invalid, Successful, Failed, Successful
Then we can check no side effect across transactions.

@devbugging
Copy link
Contributor Author

Update the test contract and add a function that adds prime numbers to the list of numbers, the sum of those numbers at the end should be exactly what we predict, because the sum only contains a sublist of numbers from transactions that should be added and not those that shouldn't (fail, invalid etc)

@devbugging
Copy link
Contributor Author

Test the storage method for Refund, it's being called by EVM itself and we should check that is being properly handled with no unexpected side-effects.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Jul 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flow EVM Stale Label used when marking an issue stale.
Projects
None yet
2 participants