Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Update stateDB code storage to store by hash #5198

Closed
Tracked by #5241
ramtinms opened this issue Jan 4, 2024 · 0 comments · Fixed by #5235
Closed
Tracked by #5241

[Flow EVM] Update stateDB code storage to store by hash #5198

ramtinms opened this issue Jan 4, 2024 · 0 comments · Fixed by #5235
Assignees
Labels
Milestone

Comments

@ramtinms
Copy link
Contributor

ramtinms commented Jan 4, 2024

Problem Definition

Storing codes by addresses could result in duplication, especially for the smart contract wallets that use the same code (e.g. COAs).
Since accounts already have CodeHash, updating the base view to store codes by CodeHash instead of address can be a way to achieve this, though we also need some mechanism like ref counting to handle the case of removing a code if no one is referencing it (no garbage behind policy).

Proposed Solution

What are the proposed solutions to this problem?

Definition of Done

What tests must pass for this issue to be considered solved?

Actions Needed Before Submitting

Update ticket status using the following (remove this section once ticket created)

  • What workstream does this ticket deal with? Find the appropriate 'S-' label and add that label.
  • Is it a specific 'type' of ticket (ex: bug, documentation)? If yes, add that label as well.
  • Is this ticket related to an overarching theme (ex: architecture, performance)? If yes, add that label as well.
  • Add any/all descriptive characteristic labels needed (ex: Needs Estimation, Needs Test Cases).
  • Now we should determine what release this ticket is associated with. If none, leave it blank. If it is associated with a specific release, please add it to the appropriate release.
  • If this ticket is associated with a release, we want to assign it a level of importance within that release. These labels follow the standard MoSCoW method rules. We want to look at releases and then the importance of tickets within those specific releases. So the MoSCoW label is ONLY valid when it is taken in conjunction with its release.
  • Assign this ticket a priority level (High, Medium, Low) via the appropriate label. These labels control the importance of the ticket within the sprint. For example, all P-High tickets should be worked on first, then P-Medium, then P-Low. This gives us an easy way to identify the order of priority for tickets within a specific sprint.
@ramtinms ramtinms self-assigned this Jan 4, 2024
@j1010001 j1010001 added this to the Flow-EVM-M1 milestone Jan 16, 2024
@j1010001 j1010001 changed the title [Beyond EVM] Update stateDB code storage to store by hash [Flow EVM] Update stateDB code storage to store by hash Jan 16, 2024
@j1010001 j1010001 modified the milestone: Flow-EVM-M1 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants