Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow EVM] - evm non-fatal runtime errors are not handled properly by FVM #5149

Closed
Tracked by #5241
ramtinms opened this issue Dec 14, 2023 · 0 comments · Fixed by #5216
Closed
Tracked by #5241

[Flow EVM] - evm non-fatal runtime errors are not handled properly by FVM #5149

ramtinms opened this issue Dec 14, 2023 · 0 comments · Fixed by #5216
Assignees
@devbugging
Labels
Bug Something isn't working Flow EVM
Milestone
Flow-EVM-M1

Comments

@ramtinms
Copy link
Contributor

ramtinms commented Dec 14, 2023 •
edited
Loading

🐞 Bug Report

EVM's "execution reverted" are wrapped as "evm runtime error" but the FVM seems to consider them as internal errors.

What is the severity of this bug?

It's not a production code, we just have to fix it before releases.
@ramtinms ramtinms self-assigned this Dec 14, 2023
@ramtinms ramtinms added Flow EVM Bug Something isn't working labels Dec 14, 2023
@ramtinms ramtinms assigned devbugging and unassigned ramtinms Jan 5, 2024
@devbugging devbugging mentioned this issue Jan 9, 2024
Merged
@j1010001 j1010001 mentioned this issue Jan 16, 2024
Closed
@j1010001 j1010001 added this to the Flow-EVM-M1 milestone Jan 16, 2024
@j1010001 j1010001 changed the title [Beyond EVM] - evm non-fatal runtime errors are not handled properly by FVM [Flow EVM] - evm non-fatal runtime errors are not handled properly by FVM Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devbugging devbugging

Labels
Bug Something isn't working Flow EVM
Projects
None yet
Milestone
Flow-EVM-M1
Development

Successfully merging a pull request may close this issue.

[EVM] Handle EVM errors onflow/flow-go
3 participants
@ramtinms @j1010001 @devbugging