Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 client acceptance testing #82

Closed
Tracked by #126
m-Peter opened this issue Feb 26, 2024 · 2 comments
Closed
Tracked by #126

Web3 client acceptance testing #82

m-Peter opened this issue Feb 26, 2024 · 2 comments
Assignees

Comments

@m-Peter
Copy link
Collaborator

m-Peter commented Feb 26, 2024

Implementing tests using a known client like web3.js will give us confidence the APIs are correctly implemented. This will act as an acceptance testing of the APIs. This is not supposed to cover edge cases and complex scenarios (we have e2e and unit tests for that) it should only cover a happy path.

We should test more of the JSON-RPC API endpoints through the web3.js library.
This will help in identifying issues related to input arguments and return values.

Improve existing integration/web3 tests to be run with e2e tests. Also expand on what is being tested, use more methods. This will ensure the web3 clients can successfully communicate with the API and it's needed beside e2e tests because web3 clients sometimes rely on specific return values or schemas that we won't detect an issue with in e2e tests.

@gregsantos
Copy link

@bthaile maybe we can hit some of these is a script and use as ref on client docs side

@m-Peter
Copy link
Collaborator Author

m-Peter commented Feb 27, 2024

Here's the current JS script we got for this: https://github.com/onflow/flow-evm-gateway/blob/gregor/dev/integration/web3js/index.js. We'll certainly add more endpoints to it.

@devbugging devbugging assigned devbugging and unassigned m-Peter Mar 4, 2024
@devbugging devbugging changed the title Enrich testing of endpoints through web3.js library Web3 client acceptance testing Mar 4, 2024
@devbugging devbugging assigned m-Peter and unassigned devbugging Mar 29, 2024
@devbugging devbugging assigned devbugging and unassigned m-Peter Apr 5, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants