Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eth_estimateGas to correctly handle execution reverts #302

Closed
Tracked by #126
m-Peter opened this issue Jun 13, 2024 · 0 comments · Fixed by #303
Closed
Tracked by #126

Update eth_estimateGas to correctly handle execution reverts #302

m-Peter opened this issue Jun 13, 2024 · 0 comments · Fixed by #303
Assignees
@m-Peter
Labels
EVM Feature Improvement
Milestone
Flow-EVM-M2

Comments

@m-Peter
Copy link
Collaborator

m-Peter commented Jun 13, 2024

The Geth implementation of eth_estimateGas behaves this way, so we need to adhere to it. See: https://github.com/onflow/go-ethereum/blob/master/internal/ethapi/api.go#L1275-L1277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-Peter m-Peter

Labels
EVM Feature Improvement
Projects
🌊 Flow 4D
Archived in project
Milestone
Flow-EVM-M2
Development

Successfully merging a pull request may close this issue.

Update eth_estimateGas to correctly handle execution reverts m-Peter/flow-evm-gateway
1 participant
@m-Peter