Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Equals functions #4

Open
tarakby opened this issue Dec 8, 2023 · 0 comments
Open

Update Equals functions #4

tarakby opened this issue Dec 8, 2023 · 0 comments
Assignees
@tarakby
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@tarakby
Copy link
Collaborator

tarakby commented Dec 8, 2023

Issue to be solved

The current Equals functions for public keys and private keys make implicit assumptions about nil receivers and inputs.

Suggested Solution

The function should clarify the assumptions in the doc, and update the implementation accordingly.
@tarakby tarakby self-assigned this Dec 8, 2023
@tarakby tarakby added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2023
@tarakby tarakby mentioned this issue Dec 8, 2023
Merged
@tarakby tarakby changed the title Update Equals function Update Equals functions Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarakby tarakby

Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tarakby