Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split runtime/interpreter/value.go into multiple files #2566

Closed
Tracked by #3595
darkdrag00nv2 opened this issue Jun 12, 2023 · 1 comment · Fixed by #3609
Closed
Tracked by #3595

Split runtime/interpreter/value.go into multiple files #2566

darkdrag00nv2 opened this issue Jun 12, 2023 · 1 comment · Fixed by #3609

Comments

@darkdrag00nv2
Copy link
Contributor

Issue to be solved

The runtime/interpreter/value.go file is huge. Even the GitHub syntax highlighting gets disabled on PR reviews because of the huge size.

Suggested Solution

We should consider splitting the file into different files. A decent split can be:

  1. value_collections.go
  2. value_numbers.go
  3. value_options.go
    .. More if needed ..

value_test.go would have to be split accordingly.

@turbolent
Copy link
Member

Agreed, it's grown significantly and new value types have already been added in new files.

Logistically, the plan is to merge feature/stable-cadence into master soon, when all maybe features have been merged (e.g. Entitlements). Once that is done, and before other major PRs are started which might touch value.go, we should split it up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants