Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require value for load/store to be storable #185

Closed
1 task
turbolent opened this issue Jun 29, 2020 · 0 comments · Fixed by #251
Closed
1 task

Require value for load/store to be storable #185

turbolent opened this issue Jun 29, 2020 · 0 comments · Fixed by #251
Assignees
@turbolent
Labels
Language Breaking Change Breaks Cadence contracts deployed on Mainnet
Milestone
Sprint 19 - Post ...

Comments

@turbolent
Copy link
Member

Context

In #169 / #180 we introduced a way to determine if a type can be stored.

The load/save functions of an account should only accept storable types.

Definition of Done

  • Sema: Add the requirement that the type parameter for the load/store functions of an account must be storable
@turbolent turbolent added the Language Breaking Change Breaks Cadence contracts deployed on Mainnet label Jun 29, 2020
@turbolent turbolent self-assigned this Jun 29, 2020
@turbolent turbolent changed the title Require type parameter for load/store to be storable Require value for load/store to be storable Jul 20, 2020
@turbolent turbolent mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbolent turbolent

Labels
Language Breaking Change Breaks Cadence contracts deployed on Mainnet
Projects
None yet
Milestone
Sprint 19 - Post Beta Mainnet - Part ...
Development

Successfully merging a pull request may close this issue.

Require values passed to load and store to be storable onflow/cadence
3 participants
@turbolent @zhangchiqing @timmymmit