Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implement ERC-55 support in Extension #579

Closed
tombeckenham opened this issue Feb 23, 2025 · 1 comment · Fixed by #582
Closed

[FEATURE] Implement ERC-55 support in Extension #579

tombeckenham opened this issue Feb 23, 2025 · 1 comment · Fixed by #582
Assignees
@tombeckenham
Milestone
2.7.4 - NFT focus...

Comments

@tombeckenham
Copy link
Collaborator

tombeckenham commented Feb 23, 2025 •
edited
Loading

Issue to be solved

Implement support for ERC-55 validation for EVM and EOA addresses.

Parent issue here - Outblock/FRW#102

See https://eips.ethereum.org/EIPS/eip-55 for the algo

Suggest A Solution

See https://eips.ethereum.org/EIPS/eip-55 for the algo

  • Implement this at a low level when returning the EVM wallet address - this should automatically handle display, and signing transactions
  • (p2) Validate EVM addresses when entering for sends or storing in the addressbook
@tombeckenham tombeckenham self-assigned this Feb 23, 2025
@tombeckenham tombeckenham mentioned this issue Feb 24, 2025
Merged
5 tasks
@tombeckenham tombeckenham moved this to In Progress in Flow Wallet Feb 24, 2025
@tombeckenham tombeckenham moved this from In Progress to Ready for QA in Flow Wallet Feb 24, 2025
@tombeckenham tombeckenham linked a pull request Feb 24, 2025 that will close this issue
579-feature-implement-erc-55-support-in-extension #582
Merged
5 tasks
@Peppermint1020
Copy link
Contributor

This feature already add in extension version 2.7.4

@Peppermint1020 Peppermint1020 moved this from Ready for QA to Done in Flow Wallet Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombeckenham tombeckenham

Labels
None yet
Projects
None yet
Milestone
2.7.4 - NFT focus & ETHDenver Items
Development

Successfully merging a pull request may close this issue.

579-feature-implement-erc-55-support-in-extension onflow/FRW-Extension
2 participants
@tombeckenham @Peppermint1020