Raise a more descriptive exception if idp_sso_target_url is missing #453
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s happened to me, but still saml 2.0 requires sso url. We can change messages but from sp side it doesn’t have any meaning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If idp_sso_target_url is missing, creating the authrequest fails currently with:
NoMethodError (undefined method `+' for nil:NilClass)This is not very descriptive, so this pull request makes the exception message more helpful.
The motivation/need for this is that typically services handle the saml settings in some kind of dynamic way. If something goes wrong there and the settings are missing, it's good that ruby-saml will point them to the right direction.