Separated the create_authentication_xml_doc in two methods #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pitbulk
I ran in a problem that I can't find a good solution for.
I want to be able to add Scoping namespaces as per @tekt8tket 's PR
I do understand your need to keep the library simple
I'm also thinking that the SAML standard is pretty big, and a library cannot cover all the usecases of SAML.
Because of this, I find it imperative that the library should be open for extension.
The way Authrequest.create_authentication_xml_doc is now, with the signing of the document before it's returned, doesn't even allow easy monkey patching.
So this is what I propose, a very simple split in the
Authrequest.create_authentication_xml_doc
between the creation and population of the document, and the signing, so you can hook your code between them.What do you think?