-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax nokogiri version requirement to >= 1.5.0 #107
Conversation
does the Gemfile change need to be >= as well? |
@todd-richmond as I mentioned in #106 the |
I'll give it a try in the next build - thx |
@todd-richmond thanks, sooner you let me know sooner I can merge it 😸 |
@todd-richmond any updates? would like to merge this today |
Going to go ahead and merge for now as its critical we get a new version of the branch cut with this change today. Please let me know if this works for you @todd-richmond |
Relax nokogiri version requirement to >= 1.5.0
Sorry - no luck. Bundler still wants to choose nokogiri 1.5 by default when using Ruby 2.0. However, I was able to force the newer nokogiri by setting 1.6 in Gemfile |
@todd-richmond I think that is the best bet for now, unless this is a blocker for you for another reason? We have to allow Ruby 1.8.7 users to use Nokogiri 1.5.x still. Do you have any better ideas? |
Not a blocker for me now, but others will probably run into the same problem. 1.8.7 was retired mid last year and is strongly discouraged: https://www.ruby-lang.org/en/news/2013/06/30/we-retire-1-8-7/ Anyone using 1.8.7 is probably gem locked to old versions of your gem as well |
@todd-richmond OK, I will add this info to the readme as a workaround for now. |
No description provided.