Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IdpMetadataParser #407

Closed
pitbulk opened this issue Jul 6, 2017 · 0 comments
Closed

Improve IdpMetadataParser #407

pitbulk opened this issue Jul 6, 2017 · 0 comments

Comments

@pitbulk
Copy link
Collaborator

pitbulk commented Jul 6, 2017

At #406 we saw that if the parser is not able to read IdPDescriptor, later a
NoMethodError: undefined method `attributes' for nil:NilClass
is raised.

We may prevent that behavior and detect sooner that scenario to raise a "IdPDescriptor not found" error.
pitbulk added a commit that referenced this issue Jul 24, 2017
@pitbulk
#407. Improve IdpMetadataParser raising an ArgumentError when parser …
e9d454b 
…method receive a metadata string with no IDPSSODescriptor element
@pitbulk pitbulk closed this as completed Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pitbulk