fix(helmfile): add some idempotence to hooks (#1761)

* fix(helmfile): add some idempotence

* Update prometheus-operator-crds.sh.j2

Author: onedr0p

templates/config/kubernetes/bootstrap/apps/hooks/cilium-config.sh.j2

@@ -1,31 +1,44 @@
 #!/usr/bin/env bash
 
-wait_for_cilium_crds() {
-    local crds=(
+set -euo pipefail
+
+function wait_for_crds() {
+    local -r crds=(
         "ciliuml2announcementpolicies.cilium.io"
         "ciliumbgppeeringpolicies.cilium.io"
         "ciliumloadbalancerippools.cilium.io"
     )
 
     for crd in "${crds[@]}"; do
         until kubectl get crd "$crd" &>/dev/null; do
+            echo "Waiting for CRD '${crd}'..."
             sleep 5
         done
     done
 }
 
-apply_cilium_config() {
-    kubectl apply \
+function apply_config() {
+    echo "Checking if Cilium config needs to be applied..."
+    if kubectl diff \
         --namespace=kube-system \
-        --server-side \
-        --field-manager=kustomize-controller \
         --kustomize \
-        "${KUBERNETES_DIR}/apps/kube-system/cilium/config"
+        "${KUBERNETES_DIR}/apps/kube-system/cilium/config" &>/dev/null;
+    then
+        echo "Cilium config is up to date. Skipping..."
+    else
+        echo "Applying Cilium config..."
+        kubectl apply \
+            --namespace=kube-system \
+            --server-side \
+            --field-manager=kustomize-controller \
+            --kustomize \
+            "${KUBERNETES_DIR}/apps/kube-system/cilium/config"
+    fi
 }
 
-main() {
-    wait_for_cilium_crds
-    apply_cilium_config
+function main() {
+    wait_for_crds
+    apply_config
 }
 
-main
+main "$@"

templates/config/kubernetes/bootstrap/apps/hooks/prometheus-operator-crds.sh.j2

@@ -1,10 +1,12 @@
 #!/usr/bin/env bash
 
+set -euo pipefail
+
 # renovate: datasource=github-releases depName=prometheus-operator/prometheus-operator
 PROMETHEUS_OPERATOR_VERSION="v0.80.0"
 
-apply_prometheus_operator_crds() {
-    local crds=(
+function apply_crds() {
+    local -r crds=(
         "alertmanagerconfigs"
         "alertmanagers"
         "podmonitors"
@@ -18,15 +20,20 @@ apply_prometheus_operator_crds() {
     )
 
     for crd in "${crds[@]}"; do
-        kubectl apply \
-            --server-side \
-            --filename \
-            "https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/${PROMETHEUS_OPERATOR_VERSION}/example/prometheus-operator-crd/monitoring.coreos.com_${crd}.yaml"
+        if kubectl get crd "${crd}.monitoring.coreos.com" &>/dev/null; then
+            echo "The CRD '${crd}' already exists. Skipping..."
+        else
+            echo "Applying CRD '${crd}'..."
+            kubectl apply \
+                --server-side \
+                --filename \
+                "https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/${PROMETHEUS_OPERATOR_VERSION}/example/prometheus-operator-crd/monitoring.coreos.com_${crd}.yaml"
+        fi
     done
 }
 
-main() {
-    apply_prometheus_operator_crds
+function main() {
+    apply_crds
 }
 
-main
+main "$@"