Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng-keyboard-shortcuts disabled property is not recognized if bound to a false initialized property #96

Closed
domdeger opened this issue Oct 8, 2020 · 2 comments

Comments

@domdeger
Copy link
Contributor

domdeger commented Oct 8, 2020

When you bind a false initialized property to disabled input then the setter runs before the shortcuts input is set (when e.g. calculated in ngOnInit). The disabled property is never checked again then so the shortcuts input is set afterwards and then just registers events.

My PR #95 should fix the issue.

Thanks for this awesome library btw, it helped me and my team a lot! :)

@omridevk
Copy link
Owner

fixed in version 10.1.17

@omridevk
Copy link
Owner

Thanks @domdeger !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants