From e0d0d36d553adb4dcf7c8e4a2d659ed55927c47e Mon Sep 17 00:00:00 2001 From: Marut K Date: Tue, 21 Jul 2020 17:01:56 +0700 Subject: [PATCH 1/3] Enforce type checking during CI build --- .github/workflows/ci.yml | 1 + types/index.d.ts | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a475c34..742948d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,5 +21,6 @@ jobs: with: node-version: ${{ matrix.node-version }} - run: npm ci + - run: npx tsc --noEmit --lib es2015 types/index.d.ts - run: npm run build --if-present - run: npm test diff --git a/types/index.d.ts b/types/index.d.ts index 50cbffb..210028b 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -53,6 +53,14 @@ declare namespace Omise { country: string; zero_interest_installments: boolean; } + + interface IRequest { + chain_enabled?: boolean; + chain_return_uri?: string; + metadata_export_keys?: object; + webhook_uri?: string; + zero_interest_installments?: boolean; + } } export namespace Balance { From cbe0850727dc1b9fc6ac155bf08f3ac235a8edbc Mon Sep 17 00:00:00 2001 From: Marut K Date: Thu, 23 Jul 2020 10:19:01 +0700 Subject: [PATCH 2/3] Add IRefundRequest type --- types/index.d.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 210028b..e06b640 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -127,7 +127,7 @@ declare namespace Omise { capture(chargeID: string, callback?: ResponseCallback): Bluebird; reverse(chargeID: string, callback?: ResponseCallback): Bluebird; expire(chargeID: string, callback?: ResponseCallback): Bluebird; - createRefund(chargeID: string, callback?: ResponseCallback): Bluebird; + createRefund(chargeID: string, req: IRefundRequest, callback?: ResponseCallback): Bluebird; listRefunds(chargeID: string, callback?: ResponseCallback): Bluebird; retrieveRefund(chargeID: string, refundID: string, callback?: ResponseCallback): Bluebird; } @@ -174,6 +174,12 @@ declare namespace Omise { data: ICharge[]; } + interface IRefundRequest { + amount: number; + metadata?: { [key: string]: any }; + void?: boolean + } + interface IRefundResponse extends IBaseResponse { amount: number; currency: string; @@ -181,6 +187,7 @@ declare namespace Omise { transaction: string; created: string; voided: boolean; + metadata?: { [key: string]: any }; } } From 3e94f0186e2257c2dc4c91fbc5b9e3464d79e003 Mon Sep 17 00:00:00 2001 From: Marut K Date: Thu, 23 Jul 2020 10:25:20 +0700 Subject: [PATCH 3/3] Update release notes --- CHANGELOG.md | 3 +++ package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4b5fead..51ed400 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ All notable changes to omise-node project will be documented in this file. Use [Semantic Versioning](http://semver.org/). +## 0.8.2 - 2020-07-23 +- Add missing typescript definitions. + ## 0.8.1 - 2020-07-20 - Add `Charge.expire` API. diff --git a/package.json b/package.json index ab2a4c3..808b622 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "omise", - "version": "0.8.1", + "version": "0.8.2", "description": "Omise Node.js bindings", "main": "index.js", "types": "types/index.d.ts",