okta_app_auto_login enhancements #164
Conversation
|
Hey, thanks for adding all these to the okta_app_auto_login, we would really love to see it in the provider as soon as possible, as we have teams requesting addition of such apps and currently it is still a manual task. In the future they can just hand in PRs for this :) |
* Enhance `okta_app_auto_login` resource by adding support for user and group assignment, and allowing the `user_name_template*` attributes to be overridden. * Add missing arguments to `okta_app_auto_login` documentation. * Refactor `buildSchema()` as variadic to simplifying schema logic.
|
any thoughts @bogdanprodan-okta / @noinarisak ? |
|
We've been using the changes in this PR as a critical part of our Okta configuration since we migrated in August… I'll feel far more comfortable once this is merged and we no longer have to maintain a custom provider mirror incorporating these changes. |
|
Hi @isometry! Thanks for the PR! Could you please add or edit a test case for this functionality? PS I've already tested it on a test company with updated test cases and it's working as expected |
|
@noinarisak I think this PR is ready to be merged. |
Add a test-case for the [buildSchema] function
noinarisak
added
enhancement
okta_app_auto_loginresource by adding support for user and group assignment, and allowing theuser_name_template*attributes to be overridden.okta_app_auto_logindocumentation.buildSchema()as variadic to simplify schema logic.