Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to catch an HTTP error early in new years #221

Open
cuducos opened this issue Jan 2, 2020 · 2 comments
Open

We need to catch an HTTP error early in new years #221

cuducos opened this issue Jan 2, 2020 · 2 comments

Comments

@cuducos
Copy link
Collaborator

cuducos commented Jan 2, 2020

At this point:

urlretrieve(URL.format(self.year), file_path)

We need a solution such as @luizfzs made in okfn-brasil/serenata-de-amor#510 -- since in the first days of the year, the toolbox might try to find the dataset for the current year (which might be still unpublished).

@luizfzs
Copy link

luizfzs commented Jan 2, 2020

To be honest, I started the fix on the toolbox but I was wondering that it would be an over-engineered solution, even though it's simple-ish, so I fixed it directly on Rosie.
I can definitely create the PR for the fix on the toolbox, but it will require a new change on Rosie to make the exception handling compatible.

@cuducos
Copy link
Collaborator Author

cuducos commented Jan 2, 2020

To be honest, I started the fix on the toolbox but I was wondering that it would be an over-engineered solution, even though it's simple-ish, so I fixed it directly on Rosie.

Good point, you got me, @luizfzs!

I'll leave the issue open on the discretion of the current maintainers, but I personally rest my case -- especially because the Chamber of Deputies adapter runs year by year... it might worth it to leave the error explicitly at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants