Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .xz to .csv.xz #176

Open
cuducos opened this issue Dec 10, 2017 · 3 comments
Open

Rename .xz to .csv.xz #176

cuducos opened this issue Dec 10, 2017 · 3 comments

Comments

@cuducos
Copy link
Collaborator

cuducos commented Dec 10, 2017

As suggested by @turicas here:

What is the problem?
When we uncompress a file using the command xz -d file.xz the uncompressed file name will be file. It'd be good to have the files named xxx.csv.xz instead of xxx.xz so some software (which depends on file extension) will work properly.

How can this be addressed?

  1. Replace lines like this (see serenata_toolbox/chamber_of_deputies/dataset.py):
            .replace('.csv', '.xz') \

with:

         .replace('.csv', '.csv.xz') \

This also happens on serenata_toolbox/federal_senate/dataset.py and maybe in other places.

  1. Will also need to change all places where these files are read.

Who could help with this issue?
@cuducos?

@cuducos
Copy link
Collaborator Author

cuducos commented Dec 10, 2017

Just a quick note to anyone interested in this issue: this change will potentially broke a lot of stuff, for instance every notebook on serenata-de-amor loading .xz files, every script on serenata-toolbox, jarbas, rosie and whistleblower opening .xz files…

I do believe that adding the proper extension is helpful and we should do it any of these days. But this must be coordinated along multiple repos. Any ideas @anaschwendler and @Irio?

@willianpaixao
Copy link
Collaborator

I can implement this feature together with #199.
But almost sure that some refactoring will be needed in Rosie and Jarbas, correct?

@cuducos
Copy link
Collaborator Author

cuducos commented Oct 1, 2018

But almost sure that some refactoring will be needed in Rosie and Jarbas, correct?

I think minor adjustments in Rosie, and just updating docs in Jarbas is enough : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants