Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about browser bugs in (ok)lch rendering #95

Closed
mirisuzanne opened this issue Aug 8, 2023 · 7 comments · Fixed by #145 or #146
Closed

Warn about browser bugs in (ok)lch rendering #95

mirisuzanne opened this issue Aug 8, 2023 · 7 comments · Fixed by #145 or #146
Labels
enhancement New feature or request sprint: current

Comments

@mirisuzanne
Copy link
Member

Requested on social media:

Browser bugs to track:

@mirisuzanne mirisuzanne added the enhancement New feature or request label Aug 8, 2023
@mirisuzanne
Copy link
Member Author

I think this might be important, and we may even want to set display-p3 as the default. The current implementations of (ok)lab/lch colors are so bad, they're almost unusable. (Why did browsers ship it like this?)

@SondraE
Copy link
Contributor

SondraE commented Aug 24, 2023

Draft Proposal

https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=0%3A1&mode=design&t=RuE2m0Xo75cF0fGM-1

@jamesnw
Copy link
Contributor

jamesnw commented Aug 30, 2023

(ok)lab bug report-

https://bugs.chromium.org/p/chromium/issues/detail?id=1439722

I didn't find ones for Webkit or Firefox.

Conversation regarding this from the CSS WG- w3c/csswg-drafts#8794

@jamesnw jamesnw mentioned this issue Oct 26, 2023
@SondraE
Copy link
Contributor

SondraE commented Nov 16, 2023

@mirisuzanne @stacyk
Here are the warning-related Figma file links.
Note: I don't know why Figma is suddenly displaying green lines around various bits of the mockups, and I haven't found the way to turn that view off yet.

Incorrect implementation + Expanded Color Issue Info
https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=12%3A138&mode=design&t=4CwzTDrU2fakSiQ4-1

@mirisuzanne
Copy link
Member Author

Left some comments on the designs. It seems like we should maybe break this out into smaller stories for the specific issues and warnings.

@SondraE SondraE assigned jamesnw and unassigned SondraE Nov 22, 2023
@jgerigmeyer jgerigmeyer self-assigned this Nov 27, 2023
@jamesnw
Copy link
Contributor

jamesnw commented Nov 27, 2023

Scope

  • If an unbounded color space is selected
    - And a user has a color selected that is out of gamut in the sRGB gamut
  • Then, show the warning bar.

I removed the out of gamut check, to prevent lots of jumping around as colors are adjusted, and I don't think the usefulness is particularly tied to the user's current color.

@jgerigmeyer jgerigmeyer removed their assignment Nov 27, 2023
@jgerigmeyer jgerigmeyer assigned dvdherron and unassigned jamesnw Dec 13, 2023
@dvdherron dvdherron removed their assignment Dec 18, 2023
@stacyk stacyk removed their assignment Dec 19, 2023
@stacyk
Copy link
Member

stacyk commented Dec 19, 2023

I removed myself but I didn't assign anyone else (yet, wasn't sure what is left on 146, or if that matters here).

@jgerigmeyer jgerigmeyer assigned stacyk and unassigned stacyk Dec 19, 2023
@jgerigmeyer jgerigmeyer linked a pull request Dec 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sprint: current
Projects
None yet
6 participants