Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: release.yml needs contents: write #672

Closed
1 task done
jsoref opened this issue Feb 9, 2024 · 3 comments · Fixed by #673
Closed
1 task done

[BUG]: release.yml needs contents: write #672

jsoref opened this issue Feb 9, 2024 · 3 comments · Fixed by #673
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 9, 2024

What happened?

The merge of #669 removed too many permissions and broke the release workflow: https://github.com/octokit/request.js/actions/runs/7844069059/job/21405658705

Versions

HEAD

Relevant log output

> [12:39:06 PM] [semantic-release] › ✘  The command "git push --dry-run --no-verify https://x-access-token:[secure]@github.com/octokit/request.js.git HEAD:main" failed with the error message remote: Permission to octokit/request.js.git denied to github-actions[bot].

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jsoref jsoref added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Feb 9, 2024
@jsoref jsoref changed the title [BUG]: Release needs contents: write [BUG]: release.yml needs contents: write Feb 9, 2024
@wolfy1339
Copy link
Member

There are probably others that need write permissions

@jsoref
Copy link
Contributor Author

jsoref commented Feb 9, 2024

I'm optimistic that there aren't... I think the act of creating the release and creating this issue and the pr for it would exercise almost everything.

The exception being prettier which is disabled.

prettier indeed doesn't work on forks, but that isn't a change: https://github.com/jsoref/request.js/actions/runs/7844368925

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants