[BUG]: With parseSuccessResponseBody set to false, the return type is improperly set

[danielhjacobs]

What happened?

With this code:

  const asset = await octokit.rest.repos.getReleaseAsset({
    owner: repository.owner,
    repo: repository.repo,
    asset_id: asset_id,
    headers: {
      accept: "application/octet-stream",
    },
    request: {
      parseSuccessResponseBody: false, // required to access response as stream
    },
  });
  return await new Response(asset.data).json();

I got the error Argument of type '{ url: string; browser_download_url: string; id: number; node_id: string; name: string; label: string | null; state: "uploaded" | "open"; content_type: string; size: number; download_count: number; created_at: string; updated_at: string; uploader: { ...; } | null; }' is not assignable to parameter of type 'BodyInit | null | undefined'

Versions

Octokit 3.1.2, Node 20.

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

We are aware of the issue. Already tracking it over in octokit/types.ts#606

[danielhjacobs]

Closing as duplicate

[wolfy1339]

I created a PR that helps with this issue, octokit/types.ts#608