Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security advisory]: Prevent ReDoS Vulnerability in Authorization Header Redaction #492

Closed
1 task done
ShiyuBanzhou opened this issue Feb 9, 2025 · 4 comments
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@ShiyuBanzhou
Copy link
Contributor

What happened?

My security advisor url is here:GHSA-xx4v-prfh-6cgc
Resolves: #Solution

Versions

@octokit/request-error >=v1.0.0

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ShiyuBanzhou ShiyuBanzhou added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 9, 2025
Copy link

github-actions bot commented Feb 9, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

Please do not post security vulnerabilities publicly. Please follow the proper disclosure process at
https://github.com/github/.github/blob/main/SECURITY.md#reporting-security-issues

@ShiyuBanzhou
Copy link
Contributor Author

Hello @wolfy1339 ,
I understand your point, so all the links I provided above are private and can only be viewed by your team. The reason I submitted a public issue is that two weeks ago, I had already submitted a related issue in your other project’s endpoint, but it has not yet been addressed. I mistakenly thought that submitting a public issue would serve as a reminder for you to handle it promptly. I apologize if this caused any inconvenience or gave the impression of rushing you, that was never my intention. If you have any concerns, please feel free to contact me. My only goal is to help make your project more robust and secure. I look forward to hearing from you, and it would be greatly appreciated if you could let me know when the issue might be resolved. In fact, I’ve already sent a notification to the designated email following the security notice, but I haven’t received any response yet, and it’s been a month.
Thank you for your understanding, and I look forward to your reply.

@wolfy1339
Copy link
Member

🎉 This issue has been resolved in version 6.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

2 participants