Typescript

[gr2m]

ping @kevinpollet for updates and review when @wolfy1339 is ready

[wolfy1339]

This is pretty much in-line with the other octokit packages. I believe it's ready for a review

[gr2m]

npm run build is currently throwing for me

> pack build

@pika/pack build v0.3.7
[1/8] Validating source...
[2/8] Preparing pipeline...
      ❇️  pkg/
      » tsconfig.json [compilerOptions.target] should be "es2019", but found "5". You may encounter problems building.
[3/8] Running @pika/plugin-ts-standard-pkg...
Error: Command failed: /Users/gregor/Projects/octokit/graphql.js/node_modules/.bin/tsc --outDir /Users/gregor/Projects/octokit/graphql.js/pkg/dist-src/ -d --declarationDir /Users/gregor/Projects/octokit/graphql.js/pkg/dist-types/ --project /Users/gregor/Projects/octokit/graphql.js/tsconfig.json --declarationMap false --target es2019 --module esnext

src/graphql.ts(39,5): error TS2345: Argument of type '{}' is not assignable to parameter of type 'Endpoint'.
  Type '{}' is missing the following properties from type '{ method: Method; url: string; }': method, url
src/index.ts(4,25): error TS2732: Cannot find module '../package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension

    at makeError (/Users/gregor/Projects/octokit/graphql.js/node_modules/@pika/plugin-ts-standard-pkg/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/Users/gregor/Projects/octokit/graphql.js/node_modules/@pika/plugin-ts-standard-pkg/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)

[wolfy1339]

Ha, yes. I completely forgot those ones. Will fix

[gr2m]

oops looks like I started a review but never submitted it.

What’s left?

[gr2m]

remove the env: key, it’s no longer needed. I use it as label but now we just test Node 10

[wolfy1339]

There's only one problem left that is kinda annoying. The one with `Object.keys(). reduce` I'm not sure I have the right types for function parameters, could you double check them all?

[gr2m]

Yeah this is tricky. I spent some time on it but to no avail. It feels like Typescript is really getting into the way of a simple implementation here.

I wonder if it would be easier to have all type definitions within the repository for now (remove the require('@octokit/request/dist-types/types')), don’t worry about duplication. It might be easier to debug and ask Typescript folks for help when everything is self contained.

I think down the road I’d like to move all typescript definitions for @octokit/* reposistories into a single repo anyway, we can take care of deduplication then

[gr2m]

error.request is not the @octokit/request method, but request options (what @octokit/endpoint returns, an object with just method, url, headers and optionally body and request

[giovannidegani]

Any updates on this ? it would be really good to have TS for this lib.

[gr2m]

@giovannidegani you can look into the remaining open issues

• Typescript #25 (comment)
• Typescript #25 (review)

you can send a pull request against this branch if you like

[wolfy1339]

I have read through previous conversations, and I agree, let's deal with de-duplication later and do whats needed to get this working and make it easier

[gr2m]

👋 I'm looking into this now and will try to finish it up, as it blocks octokit/core.js#3

[gr2m]

As far as I can see the only breaking change is the named export

const { graphql } = require('@octokit/graphql')

instead of

const graphql = require('@octokit/graphql')
```

Which aligns with the other modules we converted to Typescript/ES Modules using Pika

[gr2m]

I ran the built version against the current test in master and they all passed, so I feel confident to ship this ✌️

[octokitbot]

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀