Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 4.03 compatibility #220

Closed
hcarty opened this issue Mar 1, 2016 · 13 comments
Closed

OCaml 4.03 compatibility #220

hcarty opened this issue Mar 1, 2016 · 13 comments

Comments

@hcarty
Copy link
Contributor

hcarty commented Mar 1, 2016

The ppx extension doesn't compile with 4.03.0+beta1.

@Drup
Copy link
Member

Drup commented Mar 1, 2016

I have a patch here: https://github.com/ocsigen/lwt/tree/4.03.0
You need the dev version of ppx_tools.

@hcarty
Copy link
Contributor Author

hcarty commented Mar 1, 2016

Trying to opam pin add lwt -kgit https://github.com/ocsigen/lwt.git#4.03.0 gave me this error:

# File "myocamlbuild.ml", line 767, characters 69-98:
# Error: This expression has type Ocamlbuild_plugin.Pathname.t lazy_t
#        but an expression was expected of type string
# Command exited with code 2.

@hcarty
Copy link
Contributor Author

hcarty commented Mar 1, 2016

Looks like that may be an oasis issue...

@dbuenzli
Copy link
Contributor

Would it be please possible to fix this so that we can test 4.03 well ? This is unfortunately a prequisite of utop and some people tricked me into using it.

@bikallem
Copy link
Contributor

I want to second @dbuenzli . I am using 4.03 beta and am unable to use utop since it has requirements on lwt.

@vasilisp
Copy link
Contributor

@Drup has a workaround for the OASIS issue: https://github.com/Drup/lwt/tree/4.03.0-no-oasis . You can pin that.

@Drup, we now have ppx_tools for 4.03, so I guess we should merge your PPX fix. Hopefully the OASIS issue will get fixed in OASIS.

@Drup
Copy link
Member

Drup commented Mar 29, 2016

Sorry everyone, I did this some time ago and forgot to follow on. This is now done in #227

As @vasilisp said, while waiting for a fix on oasis or an lwt release, please use my version with oasis already generated.

opam pin add lwt https://github.com/Drup/lwt.git#4.03.0-no-oasis

@bikallem
Copy link
Contributor

@Drup still failing on 4.03.0+beta1+flambda. Error below.

gcc: error: src/unix/jobs-unix/lwt_unix_job_truncate.o: No such file or director

@Drup
Copy link
Member

Drup commented Mar 30, 2016

@neolem I just tried on flambda, I can't reproduce, everything compiles fine.

@bikallem
Copy link
Contributor

@Drup It installs okay now after removing and re-adding the 4.03.0+beta1+flambda. Thanks.

@avsm
Copy link
Collaborator

avsm commented Apr 21, 2016

Any ETA on an Lwt release with this fix in? 4.03 is around the corner.

@whitequark
Copy link
Contributor

4.03 is released and lwt is still broken...

@Drup
Copy link
Member

Drup commented Apr 26, 2016

@whitequark lwt.2.5.2 is released too, and it's 4.03-compatible.

@Drup Drup closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants