Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

@oclif/plugin-help should be a production dependency #66

Closed
elliottsj opened this issue Jun 18, 2019 · 3 comments · Fixed by #68
Closed

@oclif/plugin-help should be a production dependency #66

elliottsj opened this issue Jun 18, 2019 · 3 comments · Fixed by #68

Comments

@elliottsj
Copy link

Similar to #59

I have this error when using pnpm and passing --help to my CLI project:

Error: Cannot find module '@oclif/plugin-help'

My workaround for now is to declare @oclif/plugin-help as a dependency of my project.

@RasPhilCo
Copy link
Contributor

Added as a peerDependency c6fceea

See also: oclif/oclif#256

@edmorley
Copy link

@RasPhilCo hi! Adding a new peerDependency is generally treated as a breaking change within the node ecosystem, however this was done in a patch release.

This has caused the following warning during heroku update with the heroku-api-plugin, since it depends on "@oclif/command": "^1.4.32", which meant it pulled in this patch relase.

warning "@heroku-cli/plugin-api > @oclif/[email protected]" has unmet peer dependency "@oclif/plugin-help@^2".

Please could this change be reverted, a new patch release issued, and then it re-added in a new major release? Or alternatively the peer dependency converted to a standard dependency.

Thanks :-)

@edmorley
Copy link

Many thanks :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants