-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode for code snippets #1020
Comments
@EmileTrotignon has improved the code blocks themes in #1023 |
I assume the PR changes to the color scheme in this message. That looks much improved to me! 👍 Hmm... I think I personally might like a little bit higher contrast in the dark mode (especially for keywords — and I guess the low resolution of the screenshots might make the text seem less clear), but overall the improvement is substantial and I'd rather have the new scheme from the PR than wait for a perfect bikeshed color. :D |
And the change also comes with a nice refactoring to the ways the color work, that should hopefully make it much easier to make more changes in the future. |
Low contrasts are a problem but I think it's not caused #1023 as it uses the previous colors for documentation. Thanks for having a look :) |
Code snippets in odoc HTML output are poorly readable (IMHO) in dark mode.
Here is a code snippet in dark mode:
Here is the same snippet in light mode:
Aside from the background and main foreground color the highlight colors appear to be unchanged and seem to be designed for light mode.
The text was updated successfully, but these errors were encountered: