Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Standard Library API" link to the mobile navigation menu #1584

Closed
sabine opened this issue Oct 6, 2023 · 7 comments
Closed

Add a "Standard Library API" link to the mobile navigation menu #1584

sabine opened this issue Oct 6, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers outreachy Outreachy contributions and blog posts

Comments

@sabine
Copy link
Collaborator

sabine commented Oct 6, 2023

Note: this has been selected as an Outreachy issue. To be assigned, you must have completed the instructions in #1553.

Task

In the main navigation's template header.eml, the search box of the desktop version of the main navigation contains a "Standard Library API" link:

Screenshot from 2023-10-06 09-18-24

However, the mobile version of the main navigation does not:

Screenshot 2023-10-06 at 09-20-57 Get Up and Running With OCaml · OCaml Tutorials

Add a "Standard Library API" link to the mobile main navigation in header.eml, after "Playground" and before "Get Started".

@sabine sabine added good first issue Good for newcomers outreachy Outreachy contributions and blog posts labels Oct 6, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in OCaml.org Oct 6, 2023
@kalio007
Copy link
Contributor

kalio007 commented Oct 6, 2023

@sabine @SaySayo please can i be assigned this task, I've completed the initial installation and ready to move forward, ill love to contribute to the GUI experience
Screenshot 2023-10-04 173338

@SaySayo
Copy link
Contributor

SaySayo commented Oct 6, 2023

@kalio007, you will be assigned this issue, cc @sabine

@kalio007
Copy link
Contributor

kalio007 commented Oct 6, 2023

thank you @SaySayo ill start working on it, while i wait for @sabine

@kalio007
Copy link
Contributor

kalio007 commented Oct 9, 2023

Greetings, @sabine and @SaySayo ! I trust this meets your expectations. If it does, I'm eager to proceed with creating a pull request and tackling a more assignment. Thanks
Screenshot 2023-10-09 010410

@SaySayo
Copy link
Contributor

SaySayo commented Oct 9, 2023

Can you open a pull request so I can properly review your changes? Thank you! @kalio007

@kalio007
Copy link
Contributor

kalio007 commented Oct 9, 2023

On it

@sabine
Copy link
Collaborator Author

sabine commented Oct 10, 2023

Completed by #1600

@sabine sabine closed this as completed Oct 10, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in OCaml.org Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers outreachy Outreachy contributions and blog posts
Projects
Archived in project
Development

No branches or pull requests

3 participants