From d0c9172a8e303b5ba7a7fcdf0805cc1e8d04f1ef Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Mon, 14 Nov 2022 17:13:08 -0600 Subject: [PATCH] refactor: remove temporary map used for sorting Using List.sort is just as good and [FileMap] violated our casing convention Signed-off-by: Rudi Grinberg ps-id: b09c7aa4-8014-4e9e-8d1d-18fb2b1e24d6 --- src/dune_engine/diff_promotion.ml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dune_engine/diff_promotion.ml b/src/dune_engine/diff_promotion.ml index b8a305799bf..a676d735c66 100644 --- a/src/dune_engine/diff_promotion.ml +++ b/src/dune_engine/diff_promotion.ml @@ -206,7 +206,6 @@ let filter_db files_to_promote db = let display files_to_promote = let open Fiber.O in let files = load_db () |> filter_db files_to_promote in - let module FileMap = Map.Make (File) in let+ diff_opts = Fiber.parallel_map files ~f:(fun file -> let+ diff_opt = diff_for_file file in @@ -214,5 +213,6 @@ let display files_to_promote = | Ok diff -> Some (file, diff) | Error _ -> None) in - diff_opts |> List.filter_opt |> FileMap.of_list_exn - |> FileMap.iter ~f:Print_diff.Diff.print + diff_opts |> List.filter_opt + |> List.sort ~compare:(fun (file, _) (file', _) -> File.compare file file') + |> List.iter ~f:(fun (_file, diff) -> Print_diff.Diff.print diff)