-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect .merlin but no warning when using per_module #2596
Comments
Yh, it's because the merlin ppx config is global to a directory. We have a plan with @trefis to change the way dune communicates the config to merlin and in particular make it per-file rather than per-directory. |
I understand that there is a plan like this. I think it was mentioned in the issue which led to the introduction of the warning when dune can't generate a full .merlin file. Here we were surprised because there is no such warning, dune is silent about the problem. |
Ah indeed. That seems wrong. I suppose we wanted to fix the problem where one has several |
@Khady this should be fixed with dune 2.8.0 : config is per-module now so it is no more approximated |
Why was this re-opened? |
We have a library using
per_module
in the preprocess part. It seems that dune generates an incorrect .merlin file as soon asper_module
is used. It doesn't include theFLG -ppx ...
line.An easy way to reproduce (with dune 1.10 at least) is to create a library with a single file and this dune file:
The text was updated successfully, but these errors were encountered: