Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base and dune.configurator are incompatible #1097

Closed
rgrinberg opened this issue Aug 4, 2018 · 3 comments
Closed

base and dune.configurator are incompatible #1097

rgrinberg opened this issue Aug 4, 2018 · 3 comments

Comments

@rgrinberg
Copy link
Member

Since both offer a toplevel Caml module. Implementing #1017 should fix this issue I believe if we are sick of renaming stuff.

This is affecting real users as shown here: https://discuss.ocaml.org/t/from-jbuilder-to-dune-with-a-ctypes-project/2371/3

@ghost
Copy link

ghost commented Aug 6, 2018

#1017 would only cause caml.cmi to not be installed, right? I don't believe that's enough as for the linking step all compilation unit names must be unique.

@rgrinberg
Copy link
Member Author

Ah yeah, I agree that wouldn't be enough. Automatic name mangling for the private libs, and corresponding -open for the users of these libs would solve this issue however.

@rgrinberg
Copy link
Member Author

I believe diml already fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant