diff --git a/CHANGES.md b/CHANGES.md index af15d42cd79a..0095f986fa80 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -36,6 +36,10 @@ Unreleased - Add a META rule for 'compiler-libs.native-toplevel' (#4175, @altgr) +- Use Action_builder.copy instead of Action_build.symlink when copying compiled + interfaces in virtual rules. Fix sandbox installation of implementations of + virtual packages (fixes #4190, @dannywillems) + 2.8.2 (21/01/2021) ------------------ diff --git a/src/dune_rules/virtual_rules.ml b/src/dune_rules/virtual_rules.ml index 06a9f14f4491..775763a61988 100644 --- a/src/dune_rules/virtual_rules.ml +++ b/src/dune_rules/virtual_rules.ml @@ -37,7 +37,7 @@ let setup_copy_rules_for_impl ~sctx ~dir vimpl = let vlib_obj_dir = Lib.obj_dir vlib in let add_rule = Super_context.add_rule sctx ~dir in let copy_to_obj_dir ~src ~dst = - add_rule ~loc:(Loc.of_pos __POS__) (Action_builder.symlink ~src ~dst) + add_rule ~loc:(Loc.of_pos __POS__) (Action_builder.copy ~src ~dst) in let { Lib_config.has_native; ext_obj; _ } = ctx.lib_config in let { Mode.Dict.byte; native } =